Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tahoe idp 2.5.0 #1352

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Use tahoe idp 2.5.0 #1352

merged 1 commit into from
Jun 30, 2023
+1 −1

Conversation

bryanlandia
Copy link

Change description

Use tahoe-idp-2.5.0 - Handles edge case with remaining Users without an IdP UserSocialAuth

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)
  • Chore

Related issues

https://appsembler.atlassian.net/browse/ENG-125

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@bryanlandia
Use tahoe-idp 2.5.0
9b072a4 
Handles edge case with remaining Users without an IdP UserSocialAuth
@github-actions
Copy link

Checking git merge conflicts against https://github.com/edx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 298
Current conflicts 298
Summary Good work! No added conflicts.
Comparing with master
Benchmark conflicts with main 313
Current conflicts 313
Summary Good work! No added conflicts.

@bryanlandia bryanlandia merged commit 4dcd91f into main Jun 30, 2023
@bryanlandia bryanlandia deleted the chore/use-tahoe-idp-2.5.0 branch June 30, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirtds amirtds amirtds approved these changes

@xscrio xscrio Awaiting requested review from xscrio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanlandia @amirtds